You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The delimiter can be correctly configured via WriterBuilder. WriterBuilder::build() constructs the Writer in-line and does not use Write::new().
Currently, Write::new() does not have the ability to configure the delimiter. The function should be changed to accept it as a parameter, and then WriterBuilder::build() should use Write::new() instead of duplicating the code. The delimiter field in struct Writer can be removed, because it can only be configured when creating Writer.
The text was updated successfully, but these errors were encountered:
Just a small nit. The title should be Fix CSV not Fix cvs.
Also, same mistake is in the title of #1327
gsserge
changed the title
Fix cvs Writer::new to accept delimiter and make WriterBuilder::build use it
Fix csv Writer::new to accept delimiter and make WriterBuilder::build use it
Feb 18, 2022
alamb
changed the title
Fix csv Writer::new to accept delimiter and make WriterBuilder::build use it
Fix CSV Writer::new to accept delimiter and make WriterBuilder::build use it
Mar 3, 2022
Discovered in #1324 (comment)
The delimiter can be correctly configured via
WriterBuilder
.WriterBuilder::build()
constructs theWriter
in-line and does not useWrite::new()
.Currently,
Write::new()
does not have the ability to configure the delimiter. The function should be changed to accept it as a parameter, and thenWriterBuilder::build()
should useWrite::new()
instead of duplicating the code. Thedelimiter
field instruct Writer
can be removed, because it can only be configured when creatingWriter
.The text was updated successfully, but these errors were encountered: