Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace &Option<T> with Option<&T> in some APIs #1556

Closed
tustvold opened this issue Apr 13, 2022 · 0 comments · Fixed by #1571 or #1576
Closed

Replace &Option<T> with Option<&T> in some APIs #1556

tustvold opened this issue Apr 13, 2022 · 0 comments · Fixed by #1571 or #1576
Labels
arrow Changes to the arrow crate good first issue Good for newcomers parquet Changes to the parquet crate

Comments

@tustvold
Copy link
Contributor

Is your feature request related to a problem or challenge? Please describe what you are trying to do.

Various methods in arrow and parquet return or accept &Option<T>. This is unfortunate as sometimes you want to just specify a value as not present, and do not wish to associate a lifetime with this absence of a value

Describe the solution you'd like

These instances should be replaced with Option<&T>

Describe alternatives you've considered

We could not make this change
@tustvold tustvold added good first issue Good for newcomers enhancement Any new improvement worthy of a entry in the changelog api-change Changes to the arrow API labels Apr 13, 2022
tustvold added a commit to tustvold/arrow-rs that referenced this issue Apr 13, 2022
@tustvold
Add option to skip decoding arrow metadata from parquet (apache#1459)
019cd07 
Fix inference from null logical type (apache#1557)

Replace some `&Option<T>` with `Option<&T>` (apache#1556)
@tustvold tustvold mentioned this issue Apr 13, 2022
Merged
tustvold added a commit that referenced this issue Apr 14, 2022
@tustvold @alamb
Add option to skip decoding arrow metadata from parquet (#1459) (#1558)
d701939 
* Add option to skip decoding arrow metadata from parquet (#1459)

Fix inference from null logical type (#1557)

Replace some `&Option<T>` with `Option<&T>` (#1556)

* Update parquet/src/arrow/arrow_reader.rs

Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org>

* Fmt

Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org>
@tfeda tfeda mentioned this issue Apr 15, 2022
Merged
@tustvold tustvold mentioned this issue Apr 17, 2022
Merged
@alamb alamb added parquet Changes to the parquet crate arrow Changes to the arrow crate and removed enhancement Any new improvement worthy of a entry in the changelog api-change Changes to the arrow API labels Apr 27, 2022
@alamb alamb changed the title Replace &Option<T> with Option<&T> Replace &Option<T> with Option<&T> in some APIs Apr 27, 2022
@HaoYang670 HaoYang670 mentioned this issue Nov 29, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
arrow Changes to the arrow crate good first issue Good for newcomers parquet Changes to the parquet crate
Projects
None yet
Milestone
No milestone
2 participants
@alamb @tustvold