Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Standardize creation and configuration of parquet --> Arrow readers ( ParquetRecordBatchReaderBuilder) #2427

Closed
tustvold opened this issue Aug 12, 2022 · 0 comments · Fixed by #2435
Closed

Standardize creation and configuration of parquet --> Arrow readers ( ParquetRecordBatchReaderBuilder) #2427

tustvold opened this issue Aug 12, 2022 · 0 comments · Fixed by #2435
Assignees
@tustvold
Labels
enhancement Any new improvement worthy of a entry in the changelog parquet Changes to the parquet crate

Comments

@tustvold
Copy link
Contributor

Is your feature request related to a problem or challenge? Please describe what you are trying to do.

Currently a ParquetFileArrowReader is created from a ChunkReader or an Arc<dyn FileReader>, and an optional set of ArrowReaderOptions. Then ArrowReader can be used to obtain a ParquetRecordBatchReader from this.

Not only is this interface deeply confusing, but it is unclear how to extend it to support functionality such as row filtering, predicate pushdown, etc... which needs the schema information before it can be computed, information which is only available after the file has been opened.

Describe the solution you'd like

I would like a ParquetRecordBatchReaderBuilder similar to ParquetRecordBatchStreamBuilder

Describe alternatives you've considered

Additional context
@tustvold tustvold added the enhancement Any new improvement worthy of a entry in the changelog label Aug 12, 2022
@tustvold tustvold self-assigned this Aug 12, 2022
tustvold added a commit to tustvold/arrow-rs that referenced this issue Aug 12, 2022
@tustvold
Add ParquetRecordBatchReaderBuilder (apache#2427)
aeee9f8
@tustvold tustvold mentioned this issue Aug 12, 2022
Merged
@alamb alamb changed the title Add ParquetRecordBatchReaderBuilder Standardize creation and configuration of parquet --> Arrow readers ( ParquetRecordBatchReaderBuilder) Aug 15, 2022
@alamb alamb added arrow Changes to the arrow crate parquet Changes to the parquet crate and removed arrow Changes to the arrow crate labels Aug 15, 2022
tustvold added a commit that referenced this issue Aug 15, 2022
@tustvold
Add ParquetRecordBatchReaderBuilder (#2427) (#2435)
76cfe83 
* Add ParquetRecordBatchReaderBuilder (#2427)

* Clippy

* Fix doc

* Review feedback
@alamb alamb changed the title Standardize creation and configuration of parquet --> Arrow readers ( ParquetRecordBatchReaderBuilder) Standardize creation and configuration of parquet --> Arrow readers ( ParquetRecordBatchReaderBuilder) Aug 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tustvold tustvold

Labels
enhancement Any new improvement worthy of a entry in the changelog parquet Changes to the parquet crate
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add ParquetRecordBatchReaderBuilder (#2427) tustvold/arrow-rs
2 participants
@alamb @tustvold