Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IMDSv1 Fallback for S3 #2609

Closed
tustvold opened this issue Aug 30, 2022 · 0 comments · Fixed by #2610
Closed

IMDSv1 Fallback for S3 #2609

tustvold opened this issue Aug 30, 2022 · 0 comments · Fixed by #2610
Labels
enhancement Any new improvement worthy of a entry in the changelog object-store Object Store Interface

Comments

@tustvold
Copy link
Contributor

tustvold commented Aug 30, 2022 •
edited
Loading

Is your feature request related to a problem or challenge? Please describe what you are trying to do.

Not all systems support IMDSv2, in particular kubernetes environments where the necessary multihop tweaks have not been made, or running old versions of kube2iam

Describe the solution you'd like

On receiving a 403 response we should fallback to using IMDSv1.

Describe alternatives you've considered

Additional context

Prior to #2574 we had fallback logic by accident, as we weren't validating the status code returned 😱
@tustvold tustvold added the enhancement Any new improvement worthy of a entry in the changelog label Aug 30, 2022
tustvold added a commit to tustvold/arrow-rs that referenced this issue Aug 30, 2022
@tustvold
Add IMDSv1 fallback (apache#2609)
f1e7b38
tustvold added a commit to tustvold/arrow-rs that referenced this issue Aug 30, 2022
@tustvold
Add IMDSv1 fallback (apache#2609)
0d3ae61
tustvold added a commit to tustvold/arrow-rs that referenced this issue Aug 30, 2022
@tustvold
Add IMDSv1 fallback (apache#2609)
d485141
@tustvold tustvold mentioned this issue Aug 30, 2022
Merged
tustvold added a commit to tustvold/arrow-rs that referenced this issue Aug 30, 2022
@tustvold
Add IMDSv1 fallback (apache#2609)
fb7c505
tustvold added a commit that referenced this issue Aug 30, 2022
@tustvold
Add IMDSv1 fallback (#2609) (#2610)
62eeaa5 
* Add IMDSv1 fallback (#2609)

* Add config option
@alamb alamb added the object-store Object Store Interface label Sep 2, 2022
@alamb alamb changed the title IMDSv1 Fallback IMDSv1 Fallback for S3 Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Any new improvement worthy of a entry in the changelog object-store Object Store Interface
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add IMDSv1 fallback (#2609) tustvold/arrow-rs
2 participants
@alamb @tustvold