Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Write Deprecated Min Max Statistics When ColumnOrder Signed #3526

Closed
tustvold opened this issue Jan 13, 2023 · 1 comment · Fixed by #3527
Closed

Write Deprecated Min Max Statistics When ColumnOrder Signed #3526

tustvold opened this issue Jan 13, 2023 · 1 comment · Fixed by #3527
Labels
enhancement Any new improvement worthy of a entry in the changelog good first issue Good for newcomers help wanted parquet Changes to the parquet crate

Comments

@tustvold
Copy link
Contributor

Is your feature request related to a problem or challenge? Please describe what you are trying to do.

As per the specification for backwards compatibility it is suggested to write the old min/max statistics.

Describe the solution you'd like

If the column order is signed and the writer version is v1, we should write both statistics variants.

Describe alternatives you've considered

Additional context
@tustvold tustvold added good first issue Good for newcomers enhancement Any new improvement worthy of a entry in the changelog help wanted labels Jan 13, 2023
tustvold added a commit to tustvold/arrow-rs that referenced this issue Jan 13, 2023
@tustvold
Write backwards compatible row group statistics (apache#3526)
0e2da40
@tustvold tustvold mentioned this issue Jan 13, 2023
Merged
tustvold added a commit that referenced this issue Jan 15, 2023
@tustvold
Write backwards compatible row group statistics (#3526) (#3527)
95cf030 
* Write backwards compatible row group statistics (#3526)

* More docs

* More docs
@tustvold tustvold added the parquet Changes to the parquet crate label Jan 27, 2023
@tustvold
Copy link
Contributor Author

label_issue.py automatically added labels {'parquet'} from #3527

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Any new improvement worthy of a entry in the changelog good first issue Good for newcomers help wanted parquet Changes to the parquet crate
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Write backwards compatible row group statistics (#3526) tustvold/arrow-rs
1 participant
@tustvold