Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Native Types in PageIndex #3575

Closed
tustvold opened this issue Jan 20, 2023 · 1 comment · Fixed by #3578
Closed

Use Native Types in PageIndex #3575

tustvold opened this issue Jan 20, 2023 · 1 comment · Fixed by #3578
Assignees
@tustvold
Labels
enhancement Any new improvement worthy of a entry in the changelog parquet Changes to the parquet crate

Comments

@tustvold
Copy link
Contributor

Is your feature request related to a problem or challenge? Please describe what you are trying to do.
Index currently uses NativeIndex for most variants, but uses a custom variant for booleans and byte arrays. This is unfortunate, especially as the variant for ByteArrays does not use ByteArray but Vec<u8>

Describe the solution you'd like

All variants to make use of NativeIndex

Describe alternatives you've considered

Additional context
@tustvold tustvold added the enhancement Any new improvement worthy of a entry in the changelog label Jan 20, 2023
@tustvold tustvold self-assigned this Jan 20, 2023
@tustvold tustvold mentioned this issue Jan 20, 2023
Merged
tustvold added a commit to tustvold/arrow-rs that referenced this issue Jan 20, 2023
@tustvold
Use native types in PageIndex (apache#3575)
06823dc
@tustvold tustvold mentioned this issue Jan 20, 2023
Merged
tustvold added a commit that referenced this issue Jan 23, 2023
@tustvold
Use native types in PageIndex (#3575) (#3578)
de381ec 
* Use native types in PageIndex (#3575)

* Cleanup endianess

* Format

* Cleanup test

* Add FixedLenByteArray test
@tustvold
Copy link
Contributor Author

label_issue.py automatically added labels {'parquet'} from #3573

@tustvold tustvold added the parquet Changes to the parquet crate label Jan 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tustvold tustvold

Labels
enhancement Any new improvement worthy of a entry in the changelog parquet Changes to the parquet crate
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use native types in PageIndex (#3575) tustvold/arrow-rs
1 participant
@tustvold