Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ObjectMeta Non Exhaustive #3928

Closed
tustvold opened this issue Mar 24, 2023 · 1 comment
Closed

Make ObjectMeta Non Exhaustive #3928

tustvold opened this issue Mar 24, 2023 · 1 comment
Assignees
Labels
development-process Related to development process of arrow-rs enhancement Any new improvement worthy of a entry in the changelog

Comments

@tustvold
Copy link
Contributor

Is your feature request related to a problem or challenge? Please describe what you are trying to do.

Currently the fields on ObjectMeta are public, making a breaking change to add additional metadata, such as in #2240

Describe the solution you'd like

I would like to make ObjectMeta non_exhaustive to allow adding new fields without requiring a breaking change.

This will require adding a constructor to ObjectMeta to allow it to be safely constructed outside of the crate.

Describe alternatives you've considered

Additional context

@tustvold tustvold added the enhancement Any new improvement worthy of a entry in the changelog label Mar 24, 2023
@tustvold tustvold self-assigned this Mar 24, 2023
@tustvold
Copy link
Contributor Author

Thinking about this a bit more, this is actually a feature, in that it forces implementations to consistently populate all the fields

@tustvold tustvold closed this as not planned Won't fix, can't repro, duplicate, stale Mar 24, 2023
@tustvold tustvold added the development-process Related to development process of arrow-rs label Mar 24, 2023
@tustvold tustvold reopened this Mar 28, 2023
@tustvold tustvold added development-process Related to development process of arrow-rs and removed development-process Related to development process of arrow-rs labels Mar 28, 2023
@tustvold tustvold closed this as not planned Won't fix, can't repro, duplicate, stale Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
development-process Related to development process of arrow-rs enhancement Any new improvement worthy of a entry in the changelog
Projects
None yet
Development

No branches or pull requests

1 participant