Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ETag to ObjectMeta #2240

Closed
tustvold opened this issue Jul 30, 2022 · 2 comments · Fixed by #3937
Closed

Add ETag to ObjectMeta #2240

tustvold opened this issue Jul 30, 2022 · 2 comments · Fixed by #3937
Labels
enhancement Any new improvement worthy of a entry in the changelog good first issue Good for newcomers help wanted object-store Object Store Interface

Comments

@tustvold
Copy link
Contributor

Is your feature request related to a problem or challenge? Please describe what you are trying to do.

All object stores support a notion of an ETag that uniquely identifies a resource, we should support this

Describe the solution you'd like

The challenge lies in how to support this for the InMemory and LocalFileSystem stores. In lieu of a better alternative, as described here a hash of the last modification time is likely sufficient.

Describe alternatives you've considered

Additional context

@tustvold tustvold added good first issue Good for newcomers enhancement Any new improvement worthy of a entry in the changelog help wanted object-store Object Store Interface labels Jul 30, 2022
@Weijun-H
Copy link
Member

Can you confirm if this enhancement is still needed? If it is, I am available to work on resolving it.

@tustvold
Copy link
Contributor Author

I think this would be a great addition, I will also work on #3928 to enable this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Any new improvement worthy of a entry in the changelog good first issue Good for newcomers help wanted object-store Object Store Interface
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants