-
Notifications
You must be signed in to change notification settings - Fork 791
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add etag for objectMeta #3937
Conversation
cfe988b
to
e72fbbe
Compare
e72fbbe
to
7f49282
Compare
For the actual stores, like S3, the etag is part of the response. Using a manual hash is just for in memory and filesystem where this data isn't stored |
3632169
to
b07fe31
Compare
b07fe31
to
cbbbddf
Compare
The emulator tests appear to be failing for this? |
fa15364
to
14198da
Compare
14198da
to
afab367
Compare
|
It may not be supported, we may need to make the ETag optional 🤔 |
aaf7bbe
to
c520b95
Compare
c520b95
to
47c1f44
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thank you, as this is a breaking change I'm going to hold off on merging this until I've cut the next point release which I intend to do this wewk
Which issue does this PR close?
Closes #2240
Rationale for this change
Add
Etag
forobjectMeta
as a unique identifier, which is a hash value bylast_modified
.What changes are included in this PR?
Are there any user-facing changes?