Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return Error on Invalid Config Value #4191

Closed
tustvold opened this issue May 10, 2023 · 1 comment · Fixed by #4192
Closed

Return Error on Invalid Config Value #4191

tustvold opened this issue May 10, 2023 · 1 comment · Fixed by #4192
Assignees
@tustvold
Labels
enhancement Any new improvement worthy of a entry in the changelog object-store Object Store Interface

Comments

@tustvold
Copy link
Contributor

Is your feature request related to a problem or challenge? Please describe what you are trying to do.

Currently if AWS_CHECKSUM_ALGORITHM is set to anything other than a capitilization of sha256 AmazonS3Builder::from_env will panic.

Similarly non-truthy string values will be interpreted as false, which could lead to a confusing situation where a config value of "enabled" is interpreted as false.

Describe the solution you'd like

We should return an error for these

Describe alternatives you've considered

Additional context
@tustvold tustvold added the enhancement Any new improvement worthy of a entry in the changelog label May 10, 2023
@tustvold tustvold self-assigned this May 10, 2023
tustvold added a commit to tustvold/arrow-rs that referenced this issue May 10, 2023
@tustvold
Deffered config parsing (apache#4191)
db13f79
@tustvold tustvold mentioned this issue May 10, 2023
Merged
tustvold added a commit to tustvold/arrow-rs that referenced this issue May 10, 2023
@tustvold
Deffered config parsing (apache#4191)
a6b73b1
tustvold added a commit to tustvold/arrow-rs that referenced this issue May 10, 2023
@tustvold
Deffered config parsing (apache#4191)
26be298
tustvold added a commit that referenced this issue May 10, 2023
@tustvold
Deffered config parsing (#4191) (#4192)
b314118
@tustvold tustvold added the object-store Object Store Interface label May 18, 2023
@tustvold
Copy link
Contributor Author

label_issue.py automatically added labels {'object-store'} from #4192

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tustvold tustvold

Labels
enhancement Any new improvement worthy of a entry in the changelog object-store Object Store Interface
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Deffered Object Store Config Parsing (#4191) tustvold/arrow-rs
1 participant
@tustvold