Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scalar is not exported as part of arrow (it is only exported in arrow_array) #4779

Closed
alamb opened this issue Sep 5, 2023 · 2 comments · Fixed by #4791
Closed

Scalar is not exported as part of arrow (it is only exported in arrow_array) #4779

alamb opened this issue Sep 5, 2023 · 2 comments · Fixed by #4791
Labels
arrow Changes to the arrow crate enhancement Any new improvement worthy of a entry in the changelog

Comments

@alamb
Copy link
Contributor

alamb commented Sep 5, 2023

Describe the bug

the newly introduced Scalar is not exported as part of arrow (it is only exported in arrow_array)

https://docs.rs/arrow-array/46.0.0/arrow_array/struct.Scalar.html

While I appreciate the desire to have more granular crates in arrow, forcing end users to explicitly use subcrates (and thus also patch them / keep them up to date) is inconvenient

To Reproduce

Look for scalar in Arrow
https://docs.rs/arrow/latest/arrow/index.html?search=scalar

Expected behavior
Perhaps a good way to fix this would be to explicitly re-export all of arrow_array rather than just a subset https://github.com/apache/arrow-rs/blob/master/arrow/src/array/mod.rs 🤔

Additional context
I found this while working through https://github.com/influxdata/influxdb_iox/pull/8577 (the upgrade to arrow 46 in IOx) and updating to use the new kernels

@alamb alamb added the bug label Sep 5, 2023
@tustvold tustvold added enhancement Any new improvement worthy of a entry in the changelog and removed bug labels Sep 5, 2023
@tustvold
Copy link
Contributor

tustvold commented Sep 5, 2023

I definitely think it would be good to revisit the layout of the top-level arrow crate to better reflect the crate topology. Ideally as you say it would just re-export the underlying crates as is

tustvold added a commit to tustvold/arrow-rs that referenced this issue Sep 7, 2023
tustvold added a commit to tustvold/arrow-rs that referenced this issue Sep 7, 2023
tustvold added a commit that referenced this issue Sep 7, 2023
* Re-export array crate root (#4780) (#4779)

* Clippy
@tustvold tustvold added the arrow Changes to the arrow crate label Sep 18, 2023
@tustvold
Copy link
Contributor

label_issue.py automatically added labels {'arrow'} from #4791

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate enhancement Any new improvement worthy of a entry in the changelog
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants