Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make FixedSizeBinaryArray value_data return a reference #4820

Closed
wjones127 opened this issue Sep 15, 2023 · 0 comments · Fixed by #4821
Closed

Make FixedSizeBinaryArray value_data return a reference #4820

wjones127 opened this issue Sep 15, 2023 · 0 comments · Fixed by #4821
Assignees
Labels
api-change Changes to the arrow API arrow Changes to the arrow crate enhancement Any new improvement worthy of a entry in the changelog

Comments

@wjones127
Copy link
Member

Is your feature request related to a problem or challenge? Please describe what you are trying to do.

Right now, you cannot get a reference the the value data in a FixedSizeBinaryArray. You can get a clone of the buffer from value_data.

Describe the solution you'd like

Instead of returning a clone of the buffer, just return a reference. The caller can clone the reference if they want.

Describe alternatives you've considered

Additional context

@wjones127 wjones127 added arrow Changes to the arrow crate enhancement Any new improvement worthy of a entry in the changelog api-change Changes to the arrow API labels Sep 15, 2023
@wjones127 wjones127 self-assigned this Sep 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api-change Changes to the arrow API arrow Changes to the arrow crate enhancement Any new improvement worthy of a entry in the changelog
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant