feat: support all float types in MatrixView #1282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ACTION NEEDED Lance follows the Conventional Commits specification for release automation. The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification. For details on the error please inspect the "PR Title Check" action. |
eddyxu
changed the title
eddyxu
changed the title
eddyxu
force-pushed
the
lei/matrix_view_row_iter
branch
from
e8e4e29 to
1014133
Compare
wjones127
approved these changes
Sep 15, 2023
| type Native = bf16; | ||
|
|
||
| fn as_slice(&self) -> &[Self::Native] { | ||
| todo!() |
There was a problem hiding this comment.
Hmm it looks like we are blocked here because FSB returns an owned buffer from values().
There was a problem hiding this comment.
Let's add a TODO to fix this once we have apache/arrow-rs#4820 done and released upstream.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The matrix view supports bf16/f16/f32/f64.