Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Casting List To/From LargeList in Cast Kernel #5113

Closed
Weijun-H opened this issue Nov 22, 2023 · 2 comments · Fixed by #5124
Closed

Support Casting List To/From LargeList in Cast Kernel #5113

Weijun-H opened this issue Nov 22, 2023 · 2 comments · Fixed by #5124
Labels
arrow Changes to the arrow crate enhancement Any new improvement worthy of a entry in the changelog help wanted

Comments

@Weijun-H
Copy link
Member

Weijun-H commented Nov 22, 2023 •
edited
Loading

Describe the bug

In apache/datafusion#8305 (comment), datafuction cannot cast nested List to LargeList because of can_cast_types function

To Reproduce

Expected behavior

Additional context
@Weijun-H Weijun-H added the bug label Nov 22, 2023
@tustvold tustvold added enhancement Any new improvement worthy of a entry in the changelog help wanted and removed bug labels Nov 22, 2023
@tustvold tustvold changed the title Cast nested List to LargeList Failed Support Casting List To/From LargeList in Cast Kernel Nov 22, 2023
@tustvold
Copy link
Contributor

This should be a relatively straightforward task of casting the offsets buffer

@Weijun-H Weijun-H mentioned this issue Nov 23, 2023
Closed
tustvold added a commit to tustvold/arrow-rs that referenced this issue Nov 26, 2023
@tustvold
Cleanup list casting and support nested lists (apache#5113)
3ba24d1
@tustvold tustvold mentioned this issue Nov 26, 2023
Merged
tustvold added a commit that referenced this issue Nov 27, 2023
@tustvold
Cleanup list casting and support nested lists (#5113) (#5124)
ef1cc38 
* Cleanup list casting and support nested lists (#5113)

* Clippy

* Update can_cast_types
@tustvold tustvold added the arrow Changes to the arrow crate label Jan 5, 2024
@tustvold
Copy link
Contributor

tustvold commented Jan 5, 2024

label_issue.py automatically added labels {'arrow'} from #5124

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
arrow Changes to the arrow crate enhancement Any new improvement worthy of a entry in the changelog help wanted
Projects
None yet
Milestone
No milestone
2 participants
@tustvold @Weijun-H