Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a method to return the number of skipped rows in a RowSelection #6428

Closed
progval opened this issue Sep 20, 2024 · 0 comments · Fixed by #6429
Closed

Add a method to return the number of skipped rows in a RowSelection #6428

progval opened this issue Sep 20, 2024 · 0 comments · Fixed by #6429
Labels
enhancement Any new improvement worthy of a entry in the changelog

Comments

@progval
Copy link
Contributor

progval commented Sep 20, 2024

Is your feature request related to a problem or challenge? Please describe what you are trying to do.

RowSelection has a row_count method that returns the number of selected rows, but is missing a way to count the number of de-selected rows without iterating on the selectors

Describe the solution you'd like

Implement it as RowSelection::skipped_row_count

Describe alternatives you've considered

current state, which is that users have to reimplement it themselves

Additional context

Datafusion had to implement it here:

https://github.com/apache/datafusion/blob/f2159e6cae658a0a3f561ec2d15ea948213fd0f8/datafusion/core/src/datasource/physical_plan/parquet/page_filter.rs#L271-L277

Suggested by @alamb here: apache/datafusion#12545 (comment)

@progval progval added the enhancement Any new improvement worthy of a entry in the changelog label Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Any new improvement worthy of a entry in the changelog
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant