Add RowSelection::skipped_row_count #6429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
progval
force-pushed
the
skipped_row_count
branch
from
8b7f74c
to
e95c4ed
Compare
progval
force-pushed
the
skipped_row_count
branch
from
e95c4ed
to
02aef27
Compare
progval
force-pushed
the
skipped_row_count
branch
from
02aef27
to
463d1d8
Compare
mbrobbel
approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #6428.
Rationale for this change
This spares some boilerplate to users, like Datafusion did here:
https://github.com/apache/datafusion/blob/f2159e6cae658a0a3f561ec2d15ea948213fd0f8/datafusion/core/src/datasource/physical_plan/parquet/page_filter.rs#L271-L277
Suggested by @alamb here: apache/datafusion#12545 (comment)
What changes are included in this PR?
Added
RowSelection::skipped_row_count, and tests for both it andRowSelection::row_countAre there any user-facing changes?
New method