Skip to content

Rework ValueBuilder API to work with ParentState for reliable nested rollbacks #8188

@scovich

Description

@scovich

Today, ValueBuilder::[try_]append_variant unconditionally creates and uses a ParentState::Variant, but that is incorrect when the caller is a ListBuilder or ObjectBuilder. We need to rework the API so that the caller passes their parent state.

This is also a building block that will eventually allow VariantArrayBuilder to use a ValueBuilder directly, instead of a VariantBuilder.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions