Force new cargo and target caching to fix CI #1023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
commented
Dec 10, 2021
| - name: Cache Rust dependencies | ||
| uses: actions/cache@v2 | ||
| with: | ||
| path: /github/home/target | ||
| # this key equals the ones on `linux-build-lib` for re-use | ||
| key: ${{ runner.os }}-${{ matrix.arch }}-target-cache-${{ matrix.rust }} | ||
| key: ${{ runner.os }}-${{ matrix.arch }}-target-nightly-cache3-${{ matrix.rust }} |
There was a problem hiding this comment.
given this job is using nightly and some comments suggested rustc was getting confused about what could be reused / not ensure this target isn't shared with stable versions
alamb
commented
Dec 10, 2021
| @@ -324,13 +322,12 @@ jobs: | |||
| uses: actions/cache@v2 | |||
| with: | |||
| path: /github/home/.cargo | |||
| # this key equals the ones on `linux-build-lib` for re-use | |||
| key: cargo-cache2- | |||
| key: cargo-wasm32-cache3- | |||
There was a problem hiding this comment.
make the naming consistent (already uses a different target cache, below)
|
Merging this PR in to get CI checks running cleanly again |
This was referenced Dec 10, 2021
alamb
added a commit
that referenced
this pull request
Dec 10, 2021
alamb
added a commit
that referenced
this pull request
Dec 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
closes #1022 (I hope)
Rationale for this change
The arrow CI tests that rely on nightly are crashing with some sort of rustc internal compiler error due to the internal serialization format changing.
for example: https://github.com/apache/arrow-rs/runs/4468916693?check_suite_focus=true
Also on master: https://github.com/apache/arrow-rs/runs/4474503693?check_suite_focus=true
As @b41sh pointed out #779 (comment), it seems to be a bug in rust: rust-lang/rust#91663
What changes are included in this PR?
Use a new cache key (and thus force clean builds)
Are there any user-facing changes?
No -- CI only