feat(ipc): support for reading union arrays through IPC #1140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
helgikrs
force-pushed
the
ipc-read-union
branch
2 times, most recently
from
b226278 to
ad9294b
Compare
helgikrs
force-pushed
the
ipc-read-union
branch
from
ad9294b to
48cfc70
Compare
alamb
approved these changes
Jan 6, 2022
| let batch2: std::result::Result<Vec<_>, _> = reader.collect(); | ||
| let rb = RecordBatch::try_new(schema, vec![union_array]).unwrap(); | ||
| let rb2 = roundtrip_ipc(&rb); | ||
| // TODO: equality not yet implemented for union, so we check that the length of the array is |
|
Thank you very much for this @helgikrs! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Together with #1135, closes #654.
What changes are included in this PR?
With this change, IPC serialized arrow data containing unions can be deserialized successfully. This PR includes test cases round-tripping unions through the IPC writer and reader.