-
Notifications
You must be signed in to change notification settings - Fork 875
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add add_scalar kernel #1151
Add add_scalar kernel #1151
Conversation
0a4cfb8
to
c33e680
Compare
+ One, | ||
{ | ||
#[cfg(feature = "simd")] | ||
return simd_add_scalar(&array, scalar); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you could reuse simd_float_unary_math_op
here with a small modification, that method should work for any primitive types without the restriction on T: datatypes::ArrowFloatNumericType
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good. Didn't find simd_float_unary_math_op
there. Seems okay. Let me update.
Codecov Report
@@ Coverage Diff @@
## master #1151 +/- ##
========================================
Coverage 82.55% 82.56%
========================================
Files 169 170 +1
Lines 50456 50623 +167
========================================
+ Hits 41655 41797 +142
- Misses 8801 8826 +25
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me -- thank you @viirya ❤️
Thank you @alamb ! |
Which issue does this PR close?
Closes #1153.
Rationale for this change
What changes are included in this PR?
Are there any user-facing changes?