Restrict RecordReader and friends to scalar types (#1132) #1155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tustvold
commented
Jan 11, 2022
| /// | ||
| /// [scalar]: https://doc.rust-lang.org/book/ch03-02-data-types.html#scalar-types | ||
| /// | ||
| pub trait ScalarDataType: DataType {} |
There was a problem hiding this comment.
I also considered PrimitiveDataType or PlainOldDataType but thought this was less overloaded, and corresponds to the Rust nomenclature
tustvold
changed the title
tustvold
force-pushed
the
restrict-array-reader
branch
from
ca6d938 to
6529ee9
Compare
alamb
approved these changes
Jan 11, 2022
|
Looks like a good change to me. FYI @yordan-pavlov |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #1132.
Rationale for this change
See ticket
What changes are included in this PR?
This restricts RecordReader and friends to only permit legal types
Are there any user-facing changes?
No