Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ticket reference for false positive in clippy #1181

Merged
merged 1 commit into from
Jan 15, 2022

Conversation

alamb
Copy link
Contributor

@alamb alamb commented Jan 15, 2022

  1. Add a reference to non_send_fields_in_send_ty seems to be misguided rust-lang/rust-clippy#8045 explaining why that lint is disabled

Found by @jhorstmann

@github-actions github-actions bot added the arrow Changes to the arrow crate label Jan 15, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #1181 (90fb1d1) into master (66b84f3) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1181   +/-   ##
=======================================
  Coverage   82.66%   82.66%           
=======================================
  Files         173      173           
  Lines       50902    50902           
=======================================
+ Hits        42077    42078    +1     
+ Misses       8825     8824    -1     
Impacted Files Coverage Δ
arrow/src/buffer/immutable.rs 98.92% <ø> (ø)
arrow/src/datatypes/datatype.rs 66.38% <0.00%> (-0.43%) ⬇️
arrow/src/array/transform/mod.rs 85.69% <0.00%> (+0.13%) ⬆️
parquet/src/encodings/encoding.rs 93.71% <0.00%> (+0.19%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 66b84f3...90fb1d1. Read the comment docs.

@alamb alamb merged commit e6cb77b into apache:master Jan 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants