Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add into_inner for IPC FileWriter #1236

Merged
merged 2 commits into from
Jan 24, 2022
Merged

Add into_inner for IPC FileWriter #1236

merged 2 commits into from
Jan 24, 2022

Conversation

yjshen
Copy link
Member

@yjshen yjshen commented Jan 24, 2022

Which issue does this PR close?

Closes #.

Rationale for this change

We could get the file handle out and do more appending to the underline file.

What changes are included in this PR?

  • Add into_inner for IPC FileWriter to get file handle out.

Are there any user-facing changes?

@github-actions github-actions bot added the arrow Changes to the arrow crate label Jan 24, 2022
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice addition @yjshen !

@alamb alamb merged commit ae0ad0e into apache:master Jan 24, 2022
@alamb alamb changed the title [Minor]into_inner for IPC FileWriter Add into_inner for IPC FileWriter Jan 24, 2022
@alamb alamb added the enhancement Any new improvement worthy of a entry in the changelog label Jan 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate enhancement Any new improvement worthy of a entry in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants