Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix clippy lint clippy::type_complexity #1310

Merged
merged 1 commit into from
Feb 15, 2022
Merged

Fix clippy lint clippy::type_complexity #1310

merged 1 commit into from
Feb 15, 2022

Conversation

gsserge
Copy link
Contributor

@gsserge gsserge commented Feb 14, 2022

Which issue does this PR close?

This is part of #1255

Rationale for this change

It's beneficial to run clippy as strict as possible.

What changes are included in this PR?

This PR enables clippy::type_complexity lint in the arrow crate and fixes the related code for this check to pass.

Are there any user-facing changes?

No.

@github-actions github-actions bot added the arrow Changes to the arrow crate label Feb 14, 2022
@gsserge gsserge marked this pull request as draft February 14, 2022 18:30
@gsserge gsserge marked this pull request as ready for review February 14, 2022 18:41
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @gsserge !

This looks good to me -- clippy is being quite pedantic about the test code 😅

@alamb alamb merged commit 6e5b494 into apache:master Feb 15, 2022
@gsserge gsserge deleted the clippy_type_complexity branch February 15, 2022 18:40
@alamb alamb changed the title Enable clippy::type_complexity Fix clippy lint clippy::type_complexity Feb 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants