Clean up DictionaryArray construction in test
#1314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viirya
reviewed
Feb 15, 2022
| .build() | ||
| .unwrap(); | ||
| let dict_array = Int16DictionaryArray::from(dict_data); | ||
| let dict_array = DictionaryArray::<Int16Type>::try_new(&keys, &values).unwrap(); |
alamb
force-pushed
the
alamb/clean_array_construction
branch
from
7b700a5 to
3899a4f
Compare
nevi-me
approved these changes
Feb 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft as builds on #1296 from @viirya
Which issue does this PR close?
Re #1299
Re #1295
Rationale for this change
The new API introduced for #1299 wasn't ready in time for #1296
What changes are included in this PR?
Update a test from #1296 to use
DictionaryArray::try_newrather than directly creating buffersAre there any user-facing changes?
No