Cleanup: remove some dead / test only code #1331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
commented
Feb 17, 2022
| /// Compares the null bitmaps of two arrays using a bitwise `or` operation. | ||
| /// | ||
| /// This function is useful when implementing operations on higher level arrays. | ||
| #[allow(clippy::unnecessary_wraps)] |
There was a problem hiding this comment.
this was only used in the tests, so I moved it to the test module in this file
Codecov Report
@@ Coverage Diff @@
## master #1331 +/- ##
=======================================
Coverage 83.03% 83.03%
=======================================
Files 180 180
Lines 52919 52915 -4
=======================================
- Hits 43939 43938 -1
+ Misses 8980 8977 -3
Continue to review full report at Codecov.
|
gsserge
approved these changes
Feb 17, 2022
nevi-me
approved these changes
Feb 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Re #1255
Rationale for this change
There was some code discovered by clippy in #1324 that was legitimately dead.
What changes are included in this PR?
Remove a unused / private function and move a function used only by tests to the test module
Are there any user-facing changes?
No