Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite doc of GenericListArray #1450

Merged

Conversation

HaoYang670
Copy link
Contributor

Signed-off-by: remzi 13716567376yh@gmail.com

Which issue does this PR close?

Closes #1424.

Rationale for this change

  1. Correct the definition of GenericListArray: (a struct for variable-size list array, not for primitive array)
  2. Add link to Arrow memory layout. In this way, users and developers can quickly review the Apache Arrow standard.

Are there any user-facing changes?

Doc is updated

Signed-off-by: remzi <13716567376yh@gmail.com>
@github-actions github-actions bot added the arrow Changes to the arrow crate label Mar 16, 2022
@alamb alamb added the documentation Improvements or additions to documentation label Mar 17, 2022
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good -- thank you @HaoYang670

@alamb alamb merged commit 724eb0c into apache:master Mar 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The doc of GenericListArray is confusing
2 participants