Split out ListArrayReader into separate module (#1483) #1563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tustvold
changed the title
Codecov Report
@@ Coverage Diff @@
## master #1563 +/- ##
=======================================
Coverage 82.86% 82.86%
=======================================
Files 192 193 +1
Lines 55273 55276 +3
=======================================
+ Hits 45804 45807 +3
Misses 9469 9469
Continue to review full report at Codecov.
|
tustvold
force-pushed
the
split-out-list-array
branch
from
e58f3da to
0ae9e9f
Compare
tustvold
commented
Apr 15, 2022
| @@ -649,157 +649,6 @@ where | |||
| } | |||
| } | |||
|
|
|||
| /// Implementation of list array reader. | |||
There was a problem hiding this comment.
Moved to list_array module
tustvold
commented
Apr 15, 2022
| @@ -1690,81 +1531,6 @@ mod tests { | |||
| ); | |||
| } | |||
|
|
|||
| /// Array reader for test. | |||
There was a problem hiding this comment.
Moved to test_utils
tustvold
commented
Apr 15, 2022
| @@ -1814,180 +1580,4 @@ mod tests { | |||
| struct_array_reader.get_rep_levels() | |||
| ); | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
Moved to list_array module
alamb
approved these changes
Apr 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #1483
Rationale for this change
See ticket
What changes are included in this PR?
See ticket
Are there any user-facing changes?
The only changes are to experimental modules