expose row-group flush in public api #1634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tustvold
approved these changes
May 2, 2022
tustvold
reviewed
May 2, 2022
parquet/src/arrow/arrow_writer.rs
Outdated
| @@ -192,8 +196,8 @@ impl<W: 'static + ParquetWriter> ArrowWriter<W> { | |||
|
|
|||
| /// Close and finalize the underlying Parquet writer | |||
| pub fn close(&mut self) -> Result<parquet_format::FileMetaData> { | |||
| self.flush_completed()?; | |||
| self.flush_row_group(self.buffered_rows)?; | |||
| self.flush_excess()?; | |||
There was a problem hiding this comment.
I know this existed before, but I think it is actually redundant as write calls flush_excess
There was a problem hiding this comment.
yep, It is redundant, I didn't want to remove that on my own because it could be intentional to have defensive approach when closing writer, but right now that seems unnecessary unless more options for write popup in ArrowWriter
Codecov Report
@@ Coverage Diff @@
## master #1634 +/- ##
=======================================
Coverage 83.02% 83.03%
=======================================
Files 193 193
Lines 55577 55578 +1
=======================================
+ Hits 46145 46147 +2
+ Misses 9432 9431 -1
Continue to review full report at Codecov.
|
|
Thanks again 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #1626
Rationale for this change
more power for the users to let them decide when to flush row group
Are there any user-facing changes?
not much, just one more method with single line body