Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect null_count in generate_unions_case integration test #1713

Merged
merged 2 commits into from
May 21, 2022

Conversation

viirya
Copy link
Member

@viirya viirya commented May 19, 2022

Which issue does this PR close?

Closes #1712.

Rationale for this change

What changes are included in this PR?

Are there any user-facing changes?

@github-actions github-actions bot added the arrow Changes to the arrow crate label May 19, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #1713 (352eed8) into master (20ffaf8) will increase coverage by 0.00%.
The diff coverage is 87.50%.

❗ Current head 352eed8 differs from pull request most recent head 1c206f8. Consider uploading reports for the commit 1c206f8 to get more accurate results

@@           Coverage Diff           @@
##           master    #1713   +/-   ##
=======================================
  Coverage   83.32%   83.32%           
=======================================
  Files         195      195           
  Lines       56012    56018    +6     
=======================================
+ Hits        46671    46677    +6     
  Misses       9341     9341           
Impacted Files Coverage Δ
arrow/src/ipc/reader.rs 88.72% <80.00%> (-0.08%) ⬇️
arrow/src/ipc/writer.rs 80.37% <100.00%> (+0.06%) ⬆️
parquet_derive/src/parquet_field.rs 65.98% <0.00%> (-0.23%) ⬇️
arrow/src/array/transform/mod.rs 87.02% <0.00%> (+0.22%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 20ffaf8...1c206f8. Read the comment docs.

Copy link
Contributor

@tustvold tustvold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍. Just to check my understanding, the bug is that we wrote incorrect null counts, and the logic added to the reader is just a sanity check to make it easier to detect this in future?

@viirya
Copy link
Member Author

viirya commented May 21, 2022

@tustvold Yea, that's correct.

@viirya viirya merged commit 7b164a0 into apache:master May 21, 2022
@viirya
Copy link
Member Author

viirya commented May 21, 2022

Merged. Thanks @tustvold for review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix incorrect null_count in generate_unions_case integration test
3 participants