Pin clap to 3.1 to get CI moving (#1867) #1868
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tustvold
added
the
development-process
Codecov Report
@@ Coverage Diff @@
## master #1868 +/- ##
=======================================
Coverage 83.47% 83.47%
=======================================
Files 201 201
Lines 56987 56987
=======================================
Hits 47572 47572
Misses 9415 9415 Continue to review full report at Codecov.
|
tustvold
changed the title
Closed
jhorstmann
approved these changes
Jun 13, 2022
epage
reviewed
Jun 15, 2022
| @@ -34,7 +34,7 @@ logging = ["tracing-subscriber"] | |||
| arrow = { path = "../arrow" } | |||
| arrow-flight = { path = "../arrow-flight" } | |||
| async-trait = "0.1.41" | |||
| clap = { version = "3", features = ["derive", "env"] } | |||
| clap = { version = "~3.1", features = ["derive", "env"] } | |||
There was a problem hiding this comment.
This can now be reverted as deprecations are now off by default, see clap-rs/clap#3830 for details. When you do start working through the deprecations as part of upgrading to 4.0, we've also improved the warnings for derive users. See clap-rs/clap#3832 for examples.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #1867
Rationale for this change
This gets the pipes moving again, whilst working on trying to understand what has been changed...
What changes are included in this PR?
Pins clap to 3.1
Are there any user-facing changes?
No