Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #1882.
Rationale for this change
See #1882
What changes are included in this PR?
Removes the
indexmap
dependency to evaluate the impact on testsAre there any user-facing changes?
Yes,
arrow::json::reader::ReaderBuilder::with_format_strings
used to incorrectly take anIndexMap
aliased asHashMap
, it and other related decoder options now take aHashMap
Note that there are other crates that depend on
indexmap
.These are:
integration-testing
, inparquet
as an optional feature for binariesarrow-flight
(dependency oftonic
)arrow-flight
arrow-flight
(dependency oftonic-build
)arrow-flight
(dependency oftonic
)So if we can find a suitable resolution to the JSON writer, we could remove
indexmap
from thearrow
crate.I've also noticed that our write behaviour changes if we don't
preserve_order
on serde-json, which could be a blocker.