Move DecimalArray
to array_decimal.rs
#1986
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: remzi 13716567376yh@gmail.com
Which issue does this PR close?
Closes #1985.
Rationale for this change
DecimalArray
is a top level logical type: https://github.com/apache/arrow/blob/master/format/Schema.fbs#L405DecimalArray
has no relationship with binary arrays: Personally, I don't think the decimal array is a logical type ofFixedSizeBinaryArray
because thevalue_length
is a constant (128bits or 256bits) but not user-defined.Decimal256Array
support in the future, putting the code inarray_decimal.rs
could be more readable.What changes are included in this PR?
Are there any user-facing changes?
Yes.