-
Notifications
You must be signed in to change notification settings - Fork 847
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve performance of filter_dict #2063
Conversation
cc @sunchao |
ca23e44
to
330c8ee
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov Report
@@ Coverage Diff @@
## master #2063 +/- ##
=======================================
Coverage 83.55% 83.56%
=======================================
Files 222 222
Lines 58216 58224 +8
=======================================
+ Hits 48645 48657 +12
+ Misses 9571 9567 -4
Continue to review full report at Codecov.
|
Thanks @sunchao |
Benchmark runs are scheduled for baseline = 88e0de5 and contender = 50e285f. 50e285f is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
Which issue does this PR close?
Closes #2062.
Rationale for this change
What changes are included in this PR?
Are there any user-facing changes?