remove len field from StructBuilder #2468
Conversation
| fn validate_content(&self) { | ||
| if self.fields.len() != self.field_builders.len() { | ||
| panic!("Number of fields is not equal to the number of field_builders."); | ||
| } | ||
| if !self.field_builders.iter().all(|x| x.len() == self.len) { | ||
| if !self.field_builders.iter().all(|x| x.len() == self.len()) { |
There was a problem hiding this comment.
You could help LLVM out and lift the len from the closure, it should be smart enough to do this automatically, but it can't hurt
There was a problem hiding this comment.
Thanks for the information, I wasn't aware of this.
I shall make this change tomorrow.
|
Benchmark runs are scheduled for baseline = 63ab69e and contender = 42e9531. 42e9531 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
Which issue does this PR close?
Closes #2429.
Rationale for this change
We can get the length of the StructBuilder from the null buffer builder.
So the field StructBuilder::len is useless
What changes are included in this PR?
Removed field len from StructBuilder
Are there any user-facing changes?
No