-
Notifications
You must be signed in to change notification settings - Fork 838
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor PrimitiveBuilder Constructors #2518
Conversation
Going to get this in as the potential for conflicts is high, thank you 👍 |
Benchmark runs are scheduled for baseline = b2f0c65 and contender = 7670c5f. 7670c5f is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
The archery tests in CI pipeline failed . May have know what archery is and how to debug that failure ? |
Looks like an unrelated failure, will retry it - https://github.com/apache/arrow-rs/runs/7971887291?check_suite_focus=true |
Which issue does this PR close?
Partially implements #2054
Rationale for this change
Refactor apis to make a consistent new and with_capacity functions
What changes are included in this PR?
Removes capacity from new and added with_capacity function instead.
Are there any user-facing changes?
Yes