support LargeUtf8 in sort kernel #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #26 +/- ##
=======================================
Coverage 82.49% 82.49%
=======================================
Files 162 162
Lines 43522 43530 +8
=======================================
+ Hits 35902 35910 +8
Misses 7620 7620
Continue to review full report at Codecov.
|
jorgecarleitao
approved these changes
Apr 24, 2021
jorgecarleitao
added
the
enhancement
alamb
reviewed
Apr 26, 2021
| @@ -958,14 +962,25 @@ mod tests { | |||
| assert_eq!(output, expected) | |||
| } | |||
|
|
|||
| /// Tests both Utf8 and LargeUtf8 | |||
jorgecarleitao
removed
the
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
LargeUtf8support for the sort kernels. Closes #25