Support comparison between dictionary array and binary array #2645
Conversation
|
cc @sunchao This should be the last piece of the comparison between dictionary array and non-dictionary array. |
| @@ -2175,6 +2175,50 @@ macro_rules! typed_dict_string_array_cmp { | |||
| }}; | |||
| } | |||
|
|
|||
| #[cfg(feature = "dyn_cmp_dict")] | |||
| macro_rules! typed_dict_binary_array_cmp { | |||
There was a problem hiding this comment.
I wonder if we could use downcast_dictionary_array here?
There was a problem hiding this comment.
Yea, nice catch. We could use it here and save some code.
| @@ -2175,58 +2177,23 @@ macro_rules! typed_dict_string_array_cmp { | |||
| }}; | |||
| } | |||
|
|
|||
| #[cfg(feature = "dyn_cmp_dict")] | |||
| macro_rules! typed_dict_boolean_array_cmp { | |||
There was a problem hiding this comment.
Also removed this macro and use downcast_dictionary_array instead.
|
Thanks. |
|
Benchmark runs are scheduled for baseline = 0c85233 and contender = 4e65952. 4e65952 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
Which issue does this PR close?
Closes #2644.
Rationale for this change
What changes are included in this PR?
Are there any user-facing changes?