json feature always requires base64 feature #2668
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It should fix build failure when only json feature is enabled.
Which issue does this PR close?
Closes #2667 .
Rationale for this change
base64 is required to compile Field::to_json_value() function.
I considered alternative of replacing
#[cfg(any(feature = "json", test)]
with#[cfg(any(all(feature = "json", feature = "base64"), test)]
, but I noticed that all json features require base64. So I chose to modify parquet/Cargo.toml instead of parquet/src/record/api.rs.What changes are included in this PR?
I've added
base64
tojson
feature.Are there any user-facing changes?
No.