Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace complicated temporal macro with generic functions #2850

Merged
merged 3 commits into from
Oct 12, 2022
Merged

Replace complicated temporal macro with generic functions #2850

merged 3 commits into from
Oct 12, 2022

Conversation

viirya
Copy link
Member

@viirya viirya commented Oct 8, 2022 •
edited
Loading

Which issue does this PR close?

Closes #2851.

Rationale for this change

What changes are included in this PR?

Are there any user-facing changes?

@github-actions github-actions bot added the arrow Changes to the arrow crate label Oct 8, 2022
@viirya
Copy link
Member Author

viirya commented Oct 10, 2022

cc @sunchao @tustvold

alamb
alamb approved these changes Oct 12, 2022
View reviewed changes
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🏅 -- this looks much nicer to me. Thank you @viirya

arrow/src/compute/kernels/temporal.rs
builder.finish()
}

fn extract_component_from_datatime_array<
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would help me to have some docstrings here that explained the parameters and types here

However this is already much easier to read than the macro so 👍

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some docstrings here. Thanks.

@viirya viirya force-pushed the remove_temporal_macro branch from ac28f11 to 66be8a4 Compare October 12, 2022 22:50
@viirya viirya merged commit f8254e7 into apache:master Oct 12, 2022
@ursabot
Copy link

ursabot commented Oct 12, 2022

Benchmark runs are scheduled for baseline = 3bb7f38 and contender = f8254e7. f8254e7 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alamb alamb alamb approved these changes

Assignees
No one assigned
Labels
arrow Changes to the arrow crate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace complicated temporal macro with generic functions
3 participants
@viirya @ursabot @alamb