Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't try to infer nullability in CSV reader #2860

Merged
merged 8 commits into from
Oct 13, 2022
Merged

Don't try to infer nullability in CSV reader #2860

merged 8 commits into from
Oct 13, 2022

Conversation

Dandandan
Copy link
Contributor

Which issue does this PR close?

Closes #2859

Rationale for this change

What changes are included in this PR?

Are there any user-facing changes?

Yes, inference always returns null datatypes for inference

@github-actions github-actions bot added the arrow Changes to the arrow crate label Oct 12, 2022
@Dandandan Dandandan changed the title Don't try to infer nulls in CSV reader Don't try to infer nullability in CSV reader Oct 12, 2022
@viirya
Copy link
Member

viirya commented Oct 12, 2022 •
edited
Loading

FYI. I'm going to fix these clippy errors (error: unclosed HTML tag) at #2862

alamb
alamb approved these changes Oct 12, 2022
View reviewed changes
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me -- thanks @Dandandan

I think it would help to put an additional comment in the docstring of infer_reader_schema saying that the inferred schema will always have
nullable fields as it may be done on a sample of the data.

arrow/src/csv/reader.rs Show resolved Hide resolved
@Dandandan @alamb
Update arrow/src/csv/reader.rs
4bd9501 
Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org>
@Dandandan
Copy link
Contributor Author

Thanks @viirya @alamb for the reviews. I will merge it after everything is green.

@Dandandan Dandandan merged commit 1397fb4 into apache:master Oct 13, 2022
@ursabot
Copy link

ursabot commented Oct 13, 2022

Benchmark runs are scheduled for baseline = 65d5576 and contender = 1397fb4. 1397fb4 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@alamb
Copy link
Contributor

alamb commented Oct 13, 2022

🎉

@alamb alamb mentioned this pull request Oct 14, 2022
Closed
Fedomn added a commit to Fedomn/sqlrs that referenced this pull request Dec 10, 2022
@Fedomn
chore: bump arrow-rs and not infer nulls in csv schema(apache/arrow-r…
25446cc 
…s#2860)

Signed-off-by: Fedomn <fedomn.ma@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alamb alamb alamb approved these changes

@viirya viirya viirya approved these changes

Assignees
No one assigned
Labels
arrow Changes to the arrow crate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Don't try to infer nulls in CSV schema inference
4 participants
@Dandandan @viirya @ursabot @alamb