-
Notifications
You must be signed in to change notification settings - Fork 847
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split out arrow-integration-test crate #2868
Split out arrow-integration-test crate #2868
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -30,7 +30,8 @@ on: | |||
- arrow-data/** | |||
- arrow-schema/** | |||
- arrow-pyarrow-integration-testing/** | |||
- integration-testing/** | |||
- arrow-integration-test/** | |||
- arrow-integration-testing/** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the similar naming is unfortunate
Thanks @tustvold |
Benchmark runs are scheduled for baseline = d67d5fb and contender = 9c5ba92. 9c5ba92 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
The actual 13.0.0 DF release uses Arrow 24.0.0, but we need to pick up 25.0.0, since it brings back the Arrow Schema/Field-to-JSON serialization code (albeit in a different crate for integration tests). apache/arrow-rs#2868 apache/arrow-rs#2724
The actual 13.0.0 DF release uses Arrow 24.0.0, but we need to pick up 25.0.0, since it brings back the Arrow Schema/Field-to-JSON serialization code (albeit in a different crate for integration tests). apache/arrow-rs#2868 apache/arrow-rs#2724
Which issue does this PR close?
Closes #2876
Rationale for this change
Splits out the code to support the arrow integration test JSON format as requested on #2724 (comment) by @maxburke
What changes are included in this PR?
Moves the arrow-integration-testing::util module into a crate which can be published
Renames the integration-testing directory to match the name of the crate ("arrow-integration-testing")
Are there any user-facing changes?
No