Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Send to the ArrayBuilder trait #291

Merged
merged 1 commit into from
May 17, 2021

Conversation

Max-Meldrum
Copy link
Contributor

Adds Send to ArrayBuilder.

Closes #290

@codecov-commenter
Copy link

Codecov Report

Merging #291 (8e3591c) into master (ce8e67c) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #291   +/-   ##
=======================================
  Coverage   82.49%   82.49%           
=======================================
  Files         162      162           
  Lines       43980    43980           
=======================================
  Hits        36282    36282           
  Misses       7698     7698           
Impacted Files Coverage Δ
arrow/src/array/builder.rs 85.29% <ø> (ø)
arrow/src/util/display.rs 29.72% <0.00%> (-0.83%) ⬇️
...-testing/src/bin/flight-test-integration-client.rs 0.00% <0.00%> (ø)
...-testing/src/bin/flight-test-integration-server.rs 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce8e67c...8e3591c. Read the comment docs.

Copy link
Member

@jorgecarleitao jorgecarleitao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @Max-Meldrum !

@alamb
Copy link
Contributor

alamb commented May 15, 2021

The integration test failure seemed related to some network problem. I have retriggered it

@alamb alamb merged commit e7d5efe into apache:master May 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Send to ArrayBuilder
4 participants