Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add optional page row count limit for parquet WriterProperties (#2941) #2942

Merged
merged 2 commits into from
Oct 27, 2022
Merged

Add optional page row count limit for parquet WriterProperties (#2941) #2942

merged 2 commits into from
Oct 27, 2022

Conversation

tustvold
Copy link
Contributor

Which issue does this PR close?

Closes #2941

Rationale for this change

What changes are included in this PR?

Are there any user-facing changes?

@github-actions github-actions bot added the parquet Changes to the parquet crate label Oct 26, 2022
@alamb alamb changed the title Add page row count limit (#2941) Add optional page row count limit for parquet WriterProperties (#2941) Oct 27, 2022
alamb
alamb approved these changes Oct 27, 2022
View reviewed changes
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great -- thank you @tustvold

parquet/src/file/properties.rs Outdated Show resolved Hide resolved
parquet/src/file/properties.rs Outdated Show resolved Hide resolved
parquet/src/file/properties.rs Outdated Show resolved Hide resolved
parquet/tests/arrow_writer_layout.rs
columns: vec![ColumnChunk {
pages: (0..20)
.map(|_| Page {
rows: 100,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not bad!

@tustvold @alamb
Apply suggestions from code review
7f2382a 
Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org>
@tustvold tustvold merged commit 880c4d9 into apache:master Oct 27, 2022
@ursabot
Copy link

ursabot commented Oct 27, 2022

Benchmark runs are scheduled for baseline = 66ea66b and contender = 880c4d9. 880c4d9 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Ted-Jiang
Ted-Jiang reviewed Nov 4, 2022
View reviewed changes
parquet/src/column/writer/mod.rs
@@ -569,11 +569,13 @@ impl<'a, E: ColumnValueEncoder> GenericColumnWriter<'a, E> {
//
// In such a scenario the dictionary decoder may return an estimated encoded
// size in excess of the page size limit, even when there are no buffered values
if self.encoder.num_values() == 0 {
if self.page_metrics.num_buffered_values == 0 {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this fix the should_add_data_page bug

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not quite sure what bug you are referring to

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ted-Jiang Ted-Jiang Ted-Jiang left review comments

@alamb alamb alamb approved these changes

@viirya viirya viirya approved these changes

Assignees
No one assigned
Labels
parquet Changes to the parquet crate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Page Row Count Limit
5 participants
@tustvold @ursabot @viirya @alamb @Ted-Jiang