Split out arrow-csv (#2594) #3044
Conversation
| use chrono::prelude::*; | ||
|
|
||
| #[test] |
There was a problem hiding this comment.
These are moved to an integration test in the arrow crate
| @@ -595,105 +590,6 @@ sed do eiusmod tempor,-556132.25,1,,2019-04-18T02:45:55.555000000,23:46:03,foo | |||
| ); | |||
| } | |||
|
|
|||
| #[cfg(feature = "chrono-tz")] | |||
There was a problem hiding this comment.
Moved to integration test in arrow crate
| @@ -265,5 +264,9 @@ harness = false | |||
| required-features = ["test_utils"] | |||
|
|
|||
| [[test]] | |||
| name = "ipc_integration" | |||
| name = "ipc" | |||
There was a problem hiding this comment.
Opted to remove the redundant integration suffix
| //! use arrow::datatypes::{DataType, Field, Schema}; | ||
| //! use std::fs::File; | ||
| //! use std::sync::Arc; | ||
| //! ```no_run |
There was a problem hiding this comment.
Why is this changed to "no_run"? It seems like it is a good thing to keep testing, no?
There was a problem hiding this comment.
Because the file it reads is no longer part of this crate
Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org>
|
Benchmark runs are scheduled for baseline = a950b52 and contender = fe3318b. fe3318b is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
* Update parquet to depend on arrow subcrates (#3044) * Fix parquet_derive * Fix parquet_derive * Fix no-default-features test compilation * Fix parquet-fromcsv * Clippy
Which issue does this PR close?
Part of #2594
Rationale for this change
What changes are included in this PR?
Are there any user-facing changes?