Add more ClientConfig Options for Object Store RequestBuilder (#3127) #3256
Conversation
tustvold
force-pushed
the
add-more-client-configuration
branch
from
ef70fe1 to
fb5f443
Compare
tustvold
force-pushed
the
add-more-client-configuration
branch
from
fb5f443 to
56b20c9
Compare
| @@ -33,11 +35,25 @@ fn map_client_error(e: reqwest::Error) -> super::Error { | |||
| } | |||
| } | |||
|
|
|||
| static DEFAULT_USER_AGENT: &str = | |||
There was a problem hiding this comment.
Changing the user-agent is not a breaking change, especially given that reqwest's default include its patch version
alamb
changed the title
|
Benchmark runs are scheduled for baseline = 9833288 and contender = 2da6aab. 2da6aab is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
|
What about an option for http2_max_frame_size? |
|
I'd be happy to review a PR that added this |
Which issue does this PR close?
Closes #3127
Rationale for this change
Adds more configuration options for the HTTP client. In future we may want to tweak some of the defaults to work better with common object stores, in particular the keep alive timeouts may be higher than they should be without keep alive pings. With this PR we can find a config that works, and then bake that
What changes are included in this PR?
Are there any user-facing changes?