Split out arrow-string (#2594) #3295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tustvold
commented
Dec 8, 2022
| use std::sync::Arc; | ||
|
|
||
| use regex::Regex; | ||
| /// Perform SQL `array ~ regex_array` operation on [`StringArray`] / [`LargeStringArray`]. |
There was a problem hiding this comment.
These functions are moved from comparison.rs
tustvold
commented
Dec 8, 2022
| @@ -23,1227 +23,75 @@ | |||
| //! [here](https://doc.rust-lang.org/stable/core/arch/) for more information. | |||
| //! | |||
|
|
|||
| use crate::array::*; | |||
There was a problem hiding this comment.
The like and regex kernels are moved into arrow-string. The remaining kernels will be moved into an arrow-ord crate in a follow up PR
There was a problem hiding this comment.
What will be left in arrow-compute 🤔
There was a problem hiding this comment.
Nothing 🎉
Edit: well nothing once I also split out the arithmetic kernels, the end goal is the top-level arrow is just a re-export of other crates
crepererum
approved these changes
Dec 8, 2022
alamb
reviewed
Dec 8, 2022
| @@ -245,11 +245,10 @@ mod tests { | |||
| macro_rules! length_binary_helper { | |||
| ($offset_ty: ty, $result_ty: ty, $kernel: ident, $value: expr, $expected: expr) => {{ | |||
| let array = GenericBinaryArray::<$offset_ty>::from($value); | |||
| let result = $kernel(&array)?; | |||
| let result = $kernel(&array).unwrap(); | |||
There was a problem hiding this comment.
is this a drive by cleanup to use unwrap rather than Error in the tests?
There was a problem hiding this comment.
Yes, it means you get an actual backtrace as opposed to some random error from somewhere 😆
| @@ -23,1227 +23,75 @@ | |||
| //! [here](https://doc.rust-lang.org/stable/core/arch/) for more information. | |||
| //! | |||
|
|
|||
| use crate::array::*; | |||
There was a problem hiding this comment.
What will be left in arrow-compute 🤔
| @@ -258,6 +258,7 @@ Rust Arrow Crates: | |||
| (cd arrow-array && cargo publish) | |||
| (cd arrow-select && cargo publish) | |||
| (cd arrow-cast && cargo publish) | |||
| (cd arrow-string && cargo publish) | |||
alamb
approved these changes
Dec 8, 2022
So no changes outside the noise threshold |
This was referenced Dec 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #2594
Rationale for this change
Splits out string kernels into a crate called
arrow-string. Whilst these are primarily concerned with UTF8 strings, some also handle binary arrays. I therefore went witharrow-stringinstead ofarrow-strasstris very specifically just UTF-8 in Rust, whereas the general concept of a string extends to binary strings. Or something like that...What changes are included in this PR?
Are there any user-facing changes?