Doctests for StringArray and LargeStringArray. #330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@alamb putting this up for quick feedback. Please let me know if this is the right level of additional documentation, or if we should have more. Also, happy to include similar for more |
nevi-me
approved these changes
May 20, 2021
jorgecarleitao
added
the
documentation
jorgecarleitao
changed the title
jorgecarleitao
removed
the
documentation
alamb
approved these changes
May 20, 2021
There was a problem hiding this comment.
Thanks @novemberkilo I think this will be super helpful for users to quickly find how to create StringArray 👍
Dandandan
approved these changes
May 20, 2021
|
Thanks @novemberkilo |
8 tasks
alamb
pushed a commit
that referenced
this pull request
May 25, 2021
alamb
added a commit
that referenced
this pull request
May 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Re #301
What changes are included in this PR?
Additional doctests for
StringArrayandLargeStringArrayAre there any user-facing changes?
No