Use BufWriter when writing bloom filters and limit tests (#3318) #3319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Disable bloom filters for most tests
tustvold
commented
Dec 9, 2022
| @@ -630,7 +630,7 @@ struct ColumnProperties { | |||
| statistics_enabled: Option<EnabledStatistics>, | |||
| max_statistics_size: Option<usize>, | |||
| /// bloom filter related properties | |||
| bloom_filter_properies: Option<BloomFilterProperties>, | |||
| bloom_filter_properties: Option<BloomFilterProperties>, | |||
There was a problem hiding this comment.
This is a drive by fix of a typo
tustvold
commented
Dec 9, 2022
| @@ -177,14 +177,17 @@ impl Sbbf { | |||
| } | |||
|
|
|||
| /// Write the bloom filter data (header and then bitset) to the output | |||
| pub(crate) fn write<W: Write>(&self, mut writer: W) -> Result<(), ParquetError> { | |||
| pub(crate) fn write<W: Write>(&self, writer: W) -> Result<(), ParquetError> { | |||
| // Use a BufWriter to avoid costs of writing individual blocks | |||
There was a problem hiding this comment.
I wonder if we should be using BufWriter at a higher level 🤔 I guess we mostly don't run into this issue as we write large page sized blobs
tustvold
changed the title
viirya
approved these changes
Dec 9, 2022
|
Thank you for the quick turnaround |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #3318
Rationale for this change
The tests were taking an exceedingly long time to run, this disables them except for a few select tests that explicitly test the bloom filter.
This also adds a BufWriter when writing bloom filters, it is almost certain that this can be optimised further, but this was a quick win that took
i32_column_bloom_filterfrom taking 17 seconds to 2. This is still terrible, but not catastrophic 😅What changes are included in this PR?
Are there any user-facing changes?