Add Run End Encoding DataType #3534
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
askoa
reviewed
Jan 16, 2023
askoa
reviewed
Jan 16, 2023
arrow-schema/src/datatype.rs
Outdated
| /// | ||
| /// These child arrays are prescribed the standard names of "run_ends" and "values" | ||
| /// respectively. | ||
| RunEndEncodedType(Box<Field>, Box<Field>), |
There was a problem hiding this comment.
I am wondering what's the difference between using Box<Field> vs Box<DataType>? Dictionary uses Box<DataType> whereas Struct uses Box<Field>. I think run_ends should just be DataType as it's very similar to Buffer but in child array.
There was a problem hiding this comment.
Run-end encode type has child arrays with no buffers. Similar to Struct, I treat it as two Fields. I think it makes sense for values to be Field as it is possibly to be a dictionary. I remember it is necessary it to be a field for IPC serialization on dictionary. run-ends is just primitive one, it could be just DataType, I think.
askoa
reviewed
Jan 16, 2023
This was referenced Jan 18, 2023
|
Closing as a believe this has been superceded by #3553 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #3520.
Rationale for this change
What changes are included in this PR?
Are there any user-facing changes?